ENHANCEMENT EmailField now uses type="email" #349
Conversation
allowing email validation when using the required="required" attribute. If using an old browser, the "email" type will fallback to "text"
ENHANCEMENT use type="email" for EmailField
|
Hmmm, so by extension, we made a decision to use HTML5 by default in form fields? Because this will break validation in XHTML and HTML, right? Seems like a good default, but has broader implications than described here. On the long run, we want doctype-specific templates I guess, but too far away from that at the moment so we have to decide on one. Sean, can you add something to the upgrading docs around "Defaulting to HTML5 output for form fields", and an example on how to revert that? (through setAttribute('type', 'text')) |
|
Well we kinda already have made the call to use HTML on the front end. DateField, GridField and I'm sure others all use HTML5 data attributes which I doubt validate. |
|
it would be nice to be able to set the type of the email field without subclassing it. if you have a custom form validation then the html5 build in validation of some browsers is rather annoying |
|
If you've got custom validation already, why not just use a TextField? |
|
I mean the EmailField is good to have server side validation built-in. But for example if you have client side js validation then the html5 default validation is not so useful. |
…file-not-found Only cache shortcode if file was found
This has the benefit of allowing email validation in the browser, when using the required="required" attribute.
If using an old browser, the "email" type will fallback to "text" so it degrades gracefully in old browsers.